Comments on: List your StatusNet Bookmarks

By: chimo

chimo — Sat, 04 Aug 2012 15:53:07 +0000

Oh, sorry I misunderstood your previous comment.

Yes, you are absolutely correct. I've implemented your fix in the latest version.

Thanks :)

By: gabevl

gabevl — Sat, 04 Aug 2012 05:41:35 +0000

I did modofied the file for Reverse Favs module and yes , its working.

The other issue was with the mapping of the URL on the left side menu.If you hover the mouse over the Reverse Favs link the mapped url is yourdomain//reversefavs (remark the double // forward slash). It should be yourdomain/username/reversefavs , or as you said, in the case of a single user StatusNet instance , it should be yourdomain/reversefavs.

So, to correct this, I did that:

-in the ReverseFavsPlugin.php under function onEndPersonalGroupNav
I replaced
$action->menuItem(common_local_url('reversefavs', array('nickname' => $nickname)),
with
$action->menuItem(common_local_url('reversefavs', array('nickname' => $this->user->nickname)),

which solved my issue.

Maybe is because i use php 5.3 ...
I did install all your plugins and they do work.Kudos also for the stat plugin.

Gabriel

By: chimo

chimo — Sat, 04 Aug 2012 01:53:07 +0000

Yep, the code for the "BookmarkList" and "ReverseFavs" plugins is almost identical so they both had the same problem. I'm running PHP 5.4 and was using a syntax that caused problems with v5.3. I didn't get a chance to test the fix in a v5.3 environment so I wanted to make sure the problem was fixed before making the changes in "ReverseFavs". Thank you for your update. The "ReverseFavs" plugin should be fixed as well now. As for the URLs, if you've configured your SN instance as single-user, the URL will be "/reversefavs". If the instance is multi-user, it'll be "/username/reversefavs". I realized the "BookmarkList" README was unclear about this, so I've updated it. Let me know if you find other problems/inaccuracies

By: gabevl

gabevl — Sat, 04 Aug 2012 00:40:57 +0000

Hi chimo,

Yes, it's working...
but the same error pops up in the ReverseFavs.
I also found that the url in the left menu is constructed as :
http://yourdomain.com//reversefavs
instead of
http://yourdomain.com/username/reversefavs

Gabriel

By: chimo

chimo — Fri, 03 Aug 2012 13:35:19 +0000

Hey,
Thanks for reporting this.

I believe the issue's fixed. Can you try getting the latest version?
Let me know!

By: gabevl

gabevl — Fri, 03 Aug 2012 05:29:32 +0000

Hi chimo,

I think i found an error :

FastCGI sent in stderr: "PHP Parse error: syntax error, unexpected '[' in /var/www/plugins/BookmarkList/bookmarks.php on line 72"

and it displays a white pages ...
I use statusnet 1.1.0 and php 5.3.5

By: chimo

chimo — Sun, 15 Jul 2012 15:56:44 +0000

Hey,
I just updated the plugin so that it uses real streams: https://github.com/chimo/BookmarkList

I'm fairly new to the SN class structure, so thanks for the pointers!

By: chimo

chimo — Sun, 15 Jul 2012 15:55:19 +0000

Ahh, getting sidetracked... story of my life!

Thanks for the flattr and the comment! :)

By: Mikael "MMN-o" Nordfeldth

Mikael "MMN-o" Nordfeldth — Sun, 15 Jul 2012 04:56:34 +0000

That's great! A very sought for functionality so keep it up :)

You could probably extend ShowstreamAction or a grandparent to get the pagination functionality.

By: jpope

jpope — Sun, 15 Jul 2012 02:22:11 +0000

Man, I forgot that I had started to write this very plugin a while back. Didn't get very far actually and got sidetracked with life I guess. Works great, this should be in the default SN install. :)